Explicit fqdns in roundrobin sample CR #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsarev
requested review from
donovanmuller,
k0da,
kuritka and
somaritane
as code owners
somaritane
reviewed
Jan 11, 2021
ytsarev
force-pushed
the
clear-samples
branch
4 times, most recently
from
8297ea1 to
007b83b
Compare
* Main motivation is that roundrobin.example.com is more clear than app3.example.com especially in the demo context * Rename also app1 and app2 with their semantic meanings * Associated mass rename in docs and tests Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
ytsarev
force-pushed
the
clear-samples
branch
from
007b83b to
22ee4f0
Compare
somaritane
approved these changes
Jan 12, 2021
donovanmuller
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main motivation is that
roundrobin.example.comis more clear than
app3.example.comespecially in the demo contextRename also
app1andapp2with their semanticmeanings
Associated mass rename in docs and tests
Signed-off-by: Yury Tsarev yury.tsarev@absa.africa