Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infoblox, persistent connection #301

Closed
wants to merge 1 commit into from
Closed

Infoblox, persistent connection #301

wants to merge 1 commit into from

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Feb 16, 2021 •
edited
Loading

  • connection is created only once in Infoblox constructor function
  • provider constructor function is returning errors, so changing tests and factory
  • tested with @somaritane, @k0da against k8gb-test-nonprod-sdc

@kuritka
Infoblox, single connection
370ce4c 
 - connection is created once in infoblox constructor function
 - provider constructor function is returning errors, so changing tests and factory error handling
k0da
k0da approved these changes Feb 16, 2021
View reviewed changes
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

somaritane
somaritane approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@somaritane somaritane marked this pull request as draft February 17, 2021 08:42
@somaritane
Copy link
Contributor

@kuritka, just to confirm, are we going to close this one in favor of #312?

@kuritka
Copy link
Collaborator Author

kuritka commented Feb 22, 2021

Closed in favor of #312

@kuritka kuritka closed this Feb 22, 2021
@kuritka kuritka deleted the infoblox-single-connection-MERGE branch February 23, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0da k0da k0da approved these changes

@somaritane somaritane somaritane approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@ytsarev ytsarev Awaiting requested review from ytsarev ytsarev is a code owner

@jkremser jkremser Awaiting requested review from jkremser jkremser will be requested when the pull request is marked ready for review jkremser is a code owner

@abaguas abaguas Awaiting requested review from abaguas abaguas will be requested when the pull request is marked ready for review abaguas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuritka @somaritane @k0da