Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable coredns logging #412

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Enable coredns logging #412

merged 1 commit into from
Mar 26, 2021

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Mar 26, 2021

  • Enable log plugin
  • Move crds to templates/crds directory in chart
  • Occasional whitespace busting

Signed-off-by: Yury Tsarev yury.tsarev@absa.africa

Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change controller-gen path for crd generation

* Enable `log` plugin
* Move crds to `templates/crds` directory in chart
* Occasional whitespace busting

Signed-off-by: Yury Tsarev <yury.tsarev@absa.africa>
@ytsarev ytsarev requested a review from k0da March 26, 2021 00:22
Copy link
Collaborator

@k0da k0da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@somaritane
Copy link
Contributor

  • Enable log plugin
  • Move crds to templates/crds directory in chart
  • Occasional whitespace busting

Signed-off-by: Yury Tsarev yury.tsarev@absa.africa

@ytsarev , @k0da, is templates/crds change related to CoreDNS logging enablement or to #346 ?

@ytsarev
Copy link
Member Author

ytsarev commented Mar 26, 2021

  • Enable log plugin
  • Move crds to templates/crds directory in chart
  • Occasional whitespace busting

Signed-off-by: Yury Tsarev yury.tsarev@absa.africa

@ytsarev , @k0da, is templates/crds change related to CoreDNS logging enablement or to #346 ?

@somaritane
Well, transitively. In this PR, It is just semantic grouping for convenience. ( /crd from #346 != /templates/crd)

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ytsarev ytsarev merged commit b4e1cb7 into master Mar 26, 2021
@ytsarev ytsarev deleted the coredns-logging branch March 26, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants