Service CoreDNS Corefile by k8gb chart #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
requested changes
Apr 13, 2021
chart/k8gb/templates/coredns-cm.yaml
Outdated
Comment on lines
4
to
7
| app.kubernetes.io/managed-by: {{ .Release.Service | quote }} | ||
| app.kubernetes.io/instance: {{ .Release.Name | quote }} | ||
| helm.sh/chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}" | ||
| app.kubernetes.io/name: {{ template "coredns.name" . }} |
There was a problem hiding this comment.
Suggested change
| app.kubernetes.io/managed-by: {{ .Release.Service | quote }} | |
| app.kubernetes.io/instance: {{ .Release.Name | quote }} | |
| helm.sh/chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}" | |
| app.kubernetes.io/name: {{ template "coredns.name" . }} | |
| {{ include "chart.labels" . | indent 4 }} |
There was a problem hiding this comment.
@ytsarev thanks amended
In order to propogate dnsZone into CoreDNS Corefile we need to service configmap ourself and instruct CoreDNS chart to skip config creation. This is done by skipConfig: true option. Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
ytsarev
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to propogate dnsZone into CoreDNS Corefile we need to service
configmap ourself and instruct CoreDNS chart to skip config creation.
This is done by skipConfig: true option.
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa