Fix NS1 deployment #480
Merged
Fix NS1 deployment #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 95cd31b it was forgotted to remove unsupported flag from NS1 provider during external-dns upgrade. Also fix --ignoressl option, it doesn't take value, it is evaluated true/false by the fact option is specified Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 95cd31b it was forgotted to remove
unsupported flag from NS1 provider during external-dns upgrade.
Also fix --ignoressl option, it doesn't take value, it is evaluated
true/false by the fact option is specified
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa