Shrink NS names #490
Merged
Shrink NS names #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
kuritka
force-pushed
the
456-RFC1035-63chars-size-limit-3
branch
5 times, most recently
from
9e8fb85 to
43af203
Compare
ytsarev
reviewed
May 19, 2021
closes #456 `nsServerName` and `nsExtServerNames` - shortly nsnames are calculated from ClusterGeoTag and ExtClusterGeoTags. - DNS_ZONE k8gb-test.gslb.cloud.example.com - EDGE_DNS_ZONE: cloud.example.com - CLUSTER_GEOTAG: us will generate **gslb-ns-us-k8gb-test-gslb.cloud.example.com** Nsnames are provided by depresolver config via functions `(c *Config) GetExternalClusterNSNames() (m map[string]string)` and `(c *Config) GetClusterNSName() string` and are validated during k8gb initialization. Regarding [RFC1035](https://www.ietf.org/rfc/rfc1035.txt), particular DNS labels are validated on max length 63 characters and whole domain is validated on max length 253 characters [1](https://stackoverflow.com/questions/32290167/what-is-the-maximum-length-of-a-dns-name). Such behavior is covered by unit tests. Because nsnames are provided via config, `nsServerName(...)` and `nsServerNameExt(...)` were removed including tests. Because nsname structure had changed I had to fix `controller_tests`, `infoblox_tests`, `values.yaml` and `Makefile`. I also moved to configuration `GetExternalClusterHeartbeatFQDNs(gslbName string) (m map[string]string)` and `GetClusterHeartbeatFQDN(gslbName string) string` which are used in parallel with `GetExternalClusterNSNames()` and are also calculated from the configuration data. Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
456-RFC1035-63chars-size-limit-3
branch
from
43af203 to
0f4042e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #456
nsServerNameandnsExtServerNames- shortly, we calculate nsnames from ClusterGeoTag and ExtClusterGeoTags.DNS_ZONEk8gb-test.gslb.cloud.example.comEDGE_DNS_ZONE: cloud.example.comCLUSTER_GEOTAG: uswill generate gslb-ns-us-k8gb-test-gslb.cloud.example.com
Nsnames are provided by depresolver config via functions
(c *Config) GetExternalClusterNSNames() (m map[string]string)and(c *Config) GetClusterNSName() stringand are validated during k8gb initialization. Regarding RFC1035, particular DNS labels are validated on max length 63 characters and whole domain is validated on max length 253 characters [1]. We cover that by unit tests.Because nsnames are provided via config,
nsServerName(...)andnsServerNameExt(...)were removed including tests.Because nsname structure had changed I had to fix
controller_tests,infoblox_tests,values.yamlandMakefile.I also moved to configuration
GetExternalClusterHeartbeatFQDNs(gslbName string) (m map[string]string)andGetClusterHeartbeatFQDN(gslbName string) stringwhich are used in parallel withGetExternalClusterNSNames()and are also calculated from the configuration data.For testing I'm using gomock, which creates mock objects and asserts intermediate results. Thanks to that I'm able to assert endpoint before we save it, see
TestCreateZoneDelegationOnExternalDNSinexternal_test.go. GoMock generates mock files based on the interface. Eachmake mockswill regenerate mock files without license. That's why golic runs for each *_mock.go.Signed-off-by: kuritka kuritka@gmail.com