refactor: interface rename #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
k0da,
somaritane and
ytsarev
as code owners
k0da
previously approved these changes
May 20, 2021
In order to https://golang.org/doc/effective_go#interface-names I'm renaming interfaces IDnsProvider -> Provider IAssistant -> Assistant Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
interface_renaming
branch
from
16fa9db to
1036488
Compare
ytsarev
approved these changes
May 20, 2021
kuritka
added a commit
that referenced
this pull request
May 24, 2021
- I'm removing config settings through environment variables in controller_tests. Such functionality is covered by depresolver tests and thanks to that I'm simplifying `provideSettings` function. Also introducing new property will not require to set environment variables in two places. - In order to rename interfaces (#491) I'm regenerating mocks to get new names. Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
added a commit
that referenced
this pull request
May 26, 2021
- I'm removing config settings through environment variables in controller_tests. Such functionality is covered by depresolver tests and thanks to that I'm simplifying `provideSettings` function. Also introducing new property will not require to set environment variables in two places. - In order to rename interfaces (#491) I'm regenerating mocks to get new names. Signed-off-by: kuritka <kuritka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to https://golang.org/doc/effective_go#interface-names I'm renaming interfaces
IDnsProvider -> Provider
IAssistant -> Assistant
Signed-off-by: kuritka kuritka@gmail.com