Bump golangci-lint #610
Merged
Bump golangci-lint #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuritka
requested review from
donovanmuller,
jkremser,
k0da,
somaritane and
ytsarev
as code owners
|
@here: will require upgrade golangci locally: https://golangci-lint.run/usage/install/#macos |
kuritka
force-pushed
the
bump-golangci
branch
5 times, most recently
from
a0324f9 to
114462a
Compare
closes #609 Golangci-lint has been greatly expanded with new linter types, some of which I have integrated. With the new linters came also changes in the code, mainly - introduction of constants for repeating text - throwing out deprecated code Some of the linters were not suitable and have been commented out - golint is deprecated, revive is instead - whitespace - it's bad to have empty lines in the code, in my opinion it degrades clarity - funlen - watches the length of functions and their names - exhaustive - completing missing constants in the switch (not only default) - gomnd - force to have any number in constant. E.g. mark if len(x) > 2 , - gofmt - is part of goimports I had to change linter configuration for these: - gochecknoinits - it is bothered by wrong use of init function - it is only init() in generated code - dupl - duplicates in the code (this only applies to testing, where duplicates happen frequently. We don't mind it there) In addition I updated build pipeline. Signed-off-by: kuritka <kuritka@gmail.com>
kuritka
force-pushed
the
bump-golangci
branch
from
114462a to
67818b0
Compare
jkremser
approved these changes
Sep 9, 2021
ytsarev
reviewed
Sep 10, 2021
|
|
||
| # don't enable: | ||
| # - golint # deprecated | ||
| # - whitespace |
There was a problem hiding this comment.
I had problem with empty lines we keep in the code, which delimits block of code, e.g.: we will remove empty lines here: this
| @@ -33,7 +33,7 @@ import ( | |||
|
|
|||
| func TestFactoryInfoblox(t *testing.T) { | |||
| // arrange | |||
| client := fake.NewFakeClientWithScheme(scheme.Scheme, []runtime.Object{}...) | |||
| client := fake.NewClientBuilder().WithScheme(scheme.Scheme).WithRuntimeObjects([]runtime.Object{}...).Build() | |||
There was a problem hiding this comment.
Is it dictated by newer fake client version?
There was a problem hiding this comment.
It's deprecated. see upstream function in controller runtime: uses NewClientBuilder anyway and comment says it's deprecated. one of the new linters found that.
k0da
approved these changes
Sep 10, 2021
ytsarev
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #609
Golangci-lint has been greatly expanded with new linter types, some of which I have integrated.
With the new linters came also changes in the code, mainly
Some of the linters were not suitable and have been commented out
I had to change linter configuration for these:
In addition I updated build pipeline.
Signed-off-by: kuritka kuritka@gmail.com