Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run coredns on unpriveleged port #626

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Run coredns on unpriveleged port #626

merged 1 commit into from
Sep 22, 2021

Conversation

k0da
Copy link
Collaborator

@k0da k0da commented Sep 22, 2021

Fixes #423

Signed-off-by: Dinar Valeev dinar.valeev@absa.africa

Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
Copy link
Member

@jkremser jkremser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pls try that the

make deploy-full-local-setup still works as described in https://www.k8gb.io/docs/local.html ? I think we need to upgrade the ingress and service also here:

otherwise lgtm

edit: maybe also here: https://github.com/k8gb-io/k8gb/blob/master/Makefile#L438

@k0da
Copy link
Collaborator Author

k0da commented Sep 22, 2021

@jkremser terratest setup in CI spins up pretty much the same setup as deploy-full-local-setup. From ingress/service perspective it is still the same port 53, the change is Deployment runs on port 5353 and svc's targetPort specifies that. This is transparrent to the upper stack

@k0da k0da requested a review from jkremser September 22, 2021 15:36
@k0da k0da merged commit bc662b2 into master Sep 22, 2021
@k0da k0da deleted the targetPort branch October 14, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core dns load balancer does not get the correct targetPort
2 participants