Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grafana including example dashboard for 'podinfoes' #653

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

jkremser
Copy link
Member

make deploy-prometheus
make deploy-grafana
make demo

Grafana requires to do port-forwarding, perhaps in the future PR we could improve it a bit and open the port in k3d config

Signed-off-by: Jirka Kremser jiri.kremser@gmail.com

dashboards:
default:
k8s-node-exporter-full:
url: https://grafana.com/api/dashboards/12486/revisions/2/download
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like url contains some IDs which are runtime specific

Copy link
Member Author

@jkremser jkremser Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a runtime specific, it's referencing the existing dashboard from the grafana index - https://grafana.com/dashboards/12486 called Node Exporter Full, it's quite well known and used for resource monitoring for k8s nodes - cpu, memory
I wasn't showing it in the demo, but it was there. But good that you asked, there is actually a better one - https://grafana.com/grafana/dashboards/1860 (same name obviously)

it looks like this:
Screenshot 2021-10-13 at 16 28 19

I am putting a comment on it..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
kuritka
kuritka previously approved these changes Oct 13, 2021
Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ytsarev
ytsarev previously approved these changes Oct 14, 2021
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
@jkremser jkremser dismissed stale reviews from ytsarev and kuritka via 94c5105 October 14, 2021 09:31
@jkremser
Copy link
Member Author

jkremser commented Oct 14, 2021

I've added one more commit (the previous is the same) that removed pod name from the PR. The json was exported from the web ui, so I missed it, nice catch @kuritka

I wanted to split it to make it easier for the reviewer (old part has already been approved)

pls check also 94c5105

if we use squash and merge, this will end up as 1 commit

@jkremser jkremser requested review from kuritka, ytsarev and k0da October 14, 2021 09:35
@jkremser jkremser merged commit 78fca4b into k8gb-io:master Oct 14, 2021
@jkremser jkremser deleted the grafana branch October 14, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants