-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grafana including example dashboard for 'podinfoes' #653
Conversation
deploy/grafana/values.yaml
Outdated
dashboards: | ||
default: | ||
k8s-node-exporter-full: | ||
url: https://grafana.com/api/dashboards/12486/revisions/2/download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like url contains some IDs which are runtime specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not a runtime specific, it's referencing the existing dashboard from the grafana index - https://grafana.com/dashboards/12486 called Node Exporter Full, it's quite well known and used for resource monitoring for k8s nodes - cpu, memory
I wasn't showing it in the demo, but it was there. But good that you asked, there is actually a better one - https://grafana.com/grafana/dashboards/1860 (same name obviously)
I am putting a comment on it..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool stuff
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
I've added one more commit (the previous is the same) that removed pod name from the PR. The json was exported from the web ui, so I missed it, nice catch @kuritka I wanted to split it to make it easier for the reviewer (old part has already been approved) pls check also 94c5105 if we use squash and merge, this will end up as 1 commit |
Grafana requires to do port-forwarding, perhaps in the future PR we could improve it a bit and open the port in k3d config
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com