Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing vulnerabilities in terratests #756

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Nov 19, 2021

fixing voulnerabilities in terratest:

Screenshot 2021-11-19 at 13 38 10

fixing voulnerabilities in terratest:
 - GHSA-5j5w-g665-5m35
 - GHSA-77vh-xpmg-72qh

Signed-off-by: kuritka <kuritka@gmail.com>
@kuritka kuritka force-pushed the fix-dependabot-issues-terratest branch from 63edf14 to 5f2096e Compare November 19, 2021 12:39
Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuritka can you pls update the PR title to have some extra hints?
"GHSA-77vh-xpmg-72qh, GHSA-5j5w-g665-5m35 #756" won't look helpful in the commit history
can be something like "Fixing GHSA-77vh-xpmg-72qh, GHSA-5j5w-g665-5m35 vulnerabilities in terratests" or just "Fixing vulnerabilities in terratests"

@kuritka kuritka changed the title GHSA-77vh-xpmg-72qh, GHSA-5j5w-g665-5m35 Fixing vulnerabilities in terratests Nov 19, 2021
@kuritka
Copy link
Collaborator Author

kuritka commented Nov 19, 2021

@somaritane , done..

Copy link
Contributor

@somaritane somaritane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuritka LGTM!

@kuritka kuritka merged commit ba3c888 into master Nov 19, 2021
@kuritka kuritka deleted the fix-dependabot-issues-terratest branch November 19, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants