Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run Oh My GLB locally #87

Merged
merged 1 commit into from
Apr 20, 2020
Merged

How to run Oh My GLB locally #87

merged 1 commit into from
Apr 20, 2020

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Apr 14, 2020

Motivation

Provide simple manual to quickly spin-up local environment and check whether everything is working as expected.

  • Environment prerequisites

  • Running project locally

  • See if everything is well installed

  • See if everything running smoothly

  • Cleaning

@kuritka kuritka self-assigned this Apr 14, 2020
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider suggestions above.

Overall it's a clean and nice doc, thanks!

Meanwhile looking at #69 I'm missing Demonstration of currently implemented RoundRobin and Failover strategies part.

@kuritka do you want to handle it in the separate PR ?

docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
@ytsarev
Copy link
Member

ytsarev commented Apr 15, 2020

@kuritka something is very wrong with your branch :)
image

@kuritka kuritka force-pushed the 1_HowTo_documentation branch from e23f8ca to b97b9a2 Compare April 15, 2020 18:16
docs/how-to-run-ohmyglb.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit history is clearly messed up. Please make a clean rebase

@ytsarev ytsarev force-pushed the 1_HowTo_documentation branch from 196802b to 46ef25b Compare April 16, 2020 09:34
@ytsarev ytsarev self-requested a review April 16, 2020 09:37
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the suggested modifications and squash the commits

.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
donovanmuller
donovanmuller previously approved these changes Apr 16, 2020
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kuritka kuritka force-pushed the 1_HowTo_documentation branch 4 times, most recently from 24338c3 to 0cd7790 Compare April 17, 2020 08:45
@kuritka kuritka requested a review from ytsarev April 17, 2020 15:11
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add ohmyglb etcd readiness check. Without it jumping right to dig before etcd cluster is ready can fail user expectation

README.md Show resolved Hide resolved
@kuritka kuritka force-pushed the 1_HowTo_documentation branch from 0cd7790 to 8d87cee Compare April 19, 2020 17:54
@kuritka kuritka requested a review from ytsarev April 19, 2020 17:58
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
 - Environment prerequisites

 - Running project locally

 - Verify installation

 - Run integration tests

 - Cleaning
@kuritka kuritka force-pushed the 1_HowTo_documentation branch from 8d87cee to 2f07015 Compare April 19, 2020 18:38
@kuritka kuritka requested a review from ytsarev April 19, 2020 18:40
@kuritka kuritka merged commit 62396a1 into master Apr 20, 2020
@kuritka kuritka deleted the 1_HowTo_documentation branch May 15, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants