run go lint using github actions

.github/workflows/lint.yaml

@@ -15,8 +15,8 @@ jobs:
         uses: actions/setup-go@v4
         with:
           go-version-file: go.mod
-      - name: Lint
-        run: |
-          make lint
-          GO111MODULE=off go get github.com/kyoh86/looppointer/cmd/looppointer
-          $(go env GOPATH)/bin/looppointer ./...
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
+          version: v1.51.2

Makefile

@@ -409,7 +409,7 @@ deploy-cluster:
 ##@ Tools
 
 LINTER = $(shell pwd)/bin/golangci-lint
-LINTER_VERSION = v1.50.1
+LINTER_VERSION = v1.51.2
 .PHONY: golangci-lint
 golangci-lint:  ## Download golangci-lint locally if necessary.
 	@echo "Installing golangci-lint"

pkg/consts/helpers.go

@@ -90,10 +90,10 @@ type Int32BusinessValidator func(*int32) error
 // getInt32FromAnnotations parse integer value from annotation and return an reference to int32 object
 func extractInt32FromString(val string, businessValidator ...Int32BusinessValidator) (*int32, error) {
 	val = strings.TrimSpace(val)
-	errKey := fmt.Errorf("%s value must be a whole number", val)
+	errKey := fmt.Sprintf("%s value must be a whole number", val)
 	toInt, err := strconv.ParseInt(val, 10, 32)
 	if err != nil {
-		return nil, fmt.Errorf("error value: %w: %v", err, errKey)
+		return nil, fmt.Errorf("error value: %w: %s", err, errKey)
 	}
 	parsedInt := int32(toInt)
 	for _, validator := range businessValidator {

tests/e2e/utils/network_utils.go

@@ -177,10 +177,7 @@ func GetNextSubnetCIDRs(vnet aznetwork.VirtualNetwork, ipFamily IPFamily) ([]*ne
 	} else if ipFamily == IPv4 {
 		vnetCIDRs = append(vnetCIDRs, (*vnet.AddressSpace.AddressPrefixes)[0])
 	} else {
-		for i := range *vnet.AddressSpace.AddressPrefixes {
-			addrPrefix := (*vnet.AddressSpace.AddressPrefixes)[i]
-			vnetCIDRs = append(vnetCIDRs, addrPrefix)
-		}
+		vnetCIDRs = append(vnetCIDRs, *vnet.AddressSpace.AddressPrefixes...)
 	}
 
 	var existSubnets []string