-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator [CI] loki-operator (0.7.0) #5249
operator [CI] loki-operator (0.7.0) #5249
Conversation
318cf01
to
7e13bf7
Compare
@xperimental,@periklis , please approve as you are original reviewer(s). |
/hold @xperimental,@periklis , Please note that ci.yml was changed.
|
Dear @JoaoBraveCoding, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
1 similar comment
Dear @JoaoBraveCoding, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
7e13bf7
to
976306c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@periklis: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold cancel |
Dear @JoaoBraveCoding, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
/hold |
/hold cancel |
Dear @JoaoBraveCoding, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
/hold |
/hold cancel |
Dear @JoaoBraveCoding, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Signed-off-by: Joao Marcal <jmarcal@redhat.com>
976306c
to
db1a5e8
Compare
/merge possible |
/merge possible |
Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions
Updates to existing Operators
ci.yaml
file according to the update instructions?replaces
property if you chosereplaces-mode
via theupdateGraph
property inci.yaml
?package.yaml
orannotations.yaml
?Your submission should not
Operator Description must contain (in order)
Operator Metadata should contain
Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here