Skip to content

Commit

Permalink
go fmt sinks_test and slack (#378)
Browse files Browse the repository at this point in the history
This kept showing up in my other pull request as an issue.  I kept discarding it in that PR but here's one to fix it for good.

I ran

```
go fmt ./...
```

Signed-off-by: Sam Gleske <sam.mxracer@gmail.com>
Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
  • Loading branch information
samrocketman and AlexsJones committed Mar 20, 2024
1 parent 8b0a4bb commit eed77ae
Show file tree
Hide file tree
Showing 2 changed files with 112 additions and 113 deletions.
224 changes: 112 additions & 112 deletions pkg/sinks/sinks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,121 +72,121 @@ func Test_MattermostSinkConfigure(t *testing.T) {
}

func Test_MattermostSinkEmit(t *testing.T) {
tests := []struct {
name string
results v1alpha1.ResultSpec
responseCode int
expectError bool
}{
{
name: "Error details with successful response",
results: v1alpha1.ResultSpec{
Error: []v1alpha1.Failure{
{Text: "First error"},
{Text: "Second error"},
},
},
responseCode: http.StatusOK,
expectError: false,
},
{
name: "Non-empty details with failed response",
results: v1alpha1.ResultSpec{
Details: "Some details",
},
responseCode: http.StatusInternalServerError,
expectError: true,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
sink := &MattermostSink{
Endpoint: "",
Client: *NewClient(2 * time.Second),
}
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(tt.responseCode)
}))
defer server.Close()

sink.Endpoint = server.URL

err := sink.Emit(tt.results)

if tt.expectError {
assert.Error(t, err)
} else {
assert.NoError(t, err)
}
})
}
tests := []struct {
name string
results v1alpha1.ResultSpec
responseCode int
expectError bool
}{
{
name: "Error details with successful response",
results: v1alpha1.ResultSpec{
Error: []v1alpha1.Failure{
{Text: "First error"},
{Text: "Second error"},
},
},
responseCode: http.StatusOK,
expectError: false,
},
{
name: "Non-empty details with failed response",
results: v1alpha1.ResultSpec{
Details: "Some details",
},
responseCode: http.StatusInternalServerError,
expectError: true,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
sink := &MattermostSink{
Endpoint: "",
Client: *NewClient(2 * time.Second),
}
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(tt.responseCode)
}))
defer server.Close()

sink.Endpoint = server.URL

err := sink.Emit(tt.results)

if tt.expectError {
assert.Error(t, err)
} else {
assert.NoError(t, err)
}
})
}
}

func Test_SlackSinkConfigure(t *testing.T) {
sink := &SlackSink{}
client := NewClient(2 * time.Second)
config := v1alpha1.K8sGPT{
Spec: v1alpha1.K8sGPTSpec{
Sink: &v1alpha1.WebhookRef{
Endpoint: "http://example.com",
},
},
}

sink.Configure(config, *client, "")

assert.Equal(t, "http://example.com", sink.Endpoint)
assert.Equal(t, client, &sink.Client)
sink := &SlackSink{}
client := NewClient(2 * time.Second)
config := v1alpha1.K8sGPT{
Spec: v1alpha1.K8sGPTSpec{
Sink: &v1alpha1.WebhookRef{
Endpoint: "http://example.com",
},
},
}

sink.Configure(config, *client, "")

assert.Equal(t, "http://example.com", sink.Endpoint)
assert.Equal(t, client, &sink.Client)
}

func Test_SlackSinkEmit(t *testing.T) {
tests := []struct {
name string
results v1alpha1.ResultSpec
responseCode int
expectError bool
}{
{
name: "Successful response",
results: v1alpha1.ResultSpec{
Kind: "kind",
Name: "name",
},
responseCode: http.StatusOK,
expectError: false,
},
{
name: "Failed response",
results: v1alpha1.ResultSpec{
Kind: "kind",
Name: "name",
},
responseCode: http.StatusInternalServerError,
expectError: true,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
sink := &SlackSink{
Endpoint: "",
Client: *NewClient(2 * time.Second),
}
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(tt.responseCode)
}))
defer server.Close()

sink.Endpoint = server.URL

err := sink.Emit(tt.results)

if tt.expectError {
assert.Error(t, err)
} else {
assert.NoError(t, err)
}
})
}
}
tests := []struct {
name string
results v1alpha1.ResultSpec
responseCode int
expectError bool
}{
{
name: "Successful response",
results: v1alpha1.ResultSpec{
Kind: "kind",
Name: "name",
},
responseCode: http.StatusOK,
expectError: false,
},
{
name: "Failed response",
results: v1alpha1.ResultSpec{
Kind: "kind",
Name: "name",
},
responseCode: http.StatusInternalServerError,
expectError: true,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
sink := &SlackSink{
Endpoint: "",
Client: *NewClient(2 * time.Second),
}
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(tt.responseCode)
}))
defer server.Close()

sink.Endpoint = server.URL

err := sink.Emit(tt.results)

if tt.expectError {
assert.Error(t, err)
} else {
assert.NoError(t, err)
}
})
}
}
1 change: 0 additions & 1 deletion pkg/sinks/slack.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,3 @@ func (s *SlackSink) Emit(results v1alpha1.ResultSpec) error {

return nil
}

0 comments on commit eed77ae

Please sign in to comment.