Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add integrations support in the operator #179

Closed
2 tasks done
arbreezy opened this issue Jul 12, 2023 · 6 comments
Closed
2 tasks done

[Feature]: Add integrations support in the operator #179

arbreezy opened this issue Jul 12, 2023 · 6 comments

Comments

@arbreezy
Copy link
Member

arbreezy commented Jul 12, 2023

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

Feature parity with K8sGPT current implementation:

More specifically, the operator at the moment doesn't support the integrations feature (trivy).

Recently we introduced in k8sgpt cli a no-install subfeature in the integrations which effectively won't install Trivy.

Solution Description

K8sGPT CR will have a new integrations section to support this feature which will not install integrations but assume they are already installed
e.g trivy operator is already deployed to a K8s cluster that K8sGPT operator is running

example CR:

...  
integrations:
  trivy:
    enabled: true
...

Benefits

Feature parity with K8sGPT and ability to extend integrations support in the future

Potential Drawbacks

No response

Additional Information

No response

@eyal-sofer
Copy link

please assign me

@wujunwei
Copy link
Contributor

wujunwei commented Jul 22, 2023

If no one has started solving it yet, I will finish it by next Monday.
maybe, need some changes in project k8sgpt-ai/k8sgpt or, we can install helm chart in k8sgpt-operator itself.

@wujunwei
Copy link
Contributor

I find three ways to Implement this:

  1. need some changes in project k8sgpt-ai/k8sgpt add env or config to install trivy when server start.
  2. we can install helm chart in k8sgpt-operator directly and set active_filters in server's config file in a init container.
  3. Do it by grpc client , add new method active filter.

@arbreezy
Copy link
Member Author

hey @wujunwei ,

firstly, I can assign it to you if you want and thanks for showing interest in the project !
re: 2. I believe is better to not install anything directly to the cluster from the operator and assume trivy is already running, maybe a check if operator can find trivy's workload in a cluster.

Installing or not, integration charts like trivy, GRPC new methods will be required to interact with K8sGPT integrations handler

@AlexsJones
Copy link
Member

We are very close to this being possible now configuration API has been merged in

#201

@AlexsJones
Copy link
Member

This is a WIP #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants