-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial integration support #225
Conversation
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
I tried this version locally and here are my issues: ClusterRole k8sgpt for serviceaccount k8sgpt ClusterRole Definition in k8sgpt-operator/pkg/resources/k8sgpt.go Line 140 in 5b5fd2f
K8sGPT CRD K8sGPT CRD https://github.com/k8sgpt-ai/k8sgpt-operator/blob/main/chart/operator/templates/k8sgpt-crd.yaml needs to get updated with the latest changes in f75cbaf#diff-515c96a78fd03639770938bc9d86c9d31cfde1233911fc4d28be1609e6bc90cc |
It's not ready just yet, thanks for trying though! |
Two additional things. When this branch is used with the K8sGPT CR attribut
the issue #240 will happened, so k8sgpt-ai/k8sgpt#678 would be a prereq for this PR. And when used with
the trivy integration will still be deactivated (k8sgpt-ai/k8sgpt#670) so k8sgpt-ai/k8sgpt#675 will also be a prereq in this case. |
Good feedback thanks, I anticipate this will only work on the next k8sgpt release also as there are schema changes |
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Solves #179 |
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexsJones apart from the consideration of how privileged the cluster role is and the unresolved conflicts, it looks good to me
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Closes #
π Description
β Checks
βΉ Additional Information