Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: trivy integration not active with —-no-install #670

Closed
4 tasks done
jkleinlercher opened this issue Sep 19, 2023 · 1 comment · Fixed by #675
Closed
4 tasks done

[Bug]: trivy integration not active with —-no-install #670

jkleinlercher opened this issue Sep 19, 2023 · 1 comment · Fixed by #675

Comments

@jkleinlercher
Copy link
Contributor

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've included steps to reproduce the behavior

Affected Components

  • K8sGPT (CLI)
  • K8sGPT Operator

K8sGPT Version

V0.3.15

Kubernetes Version

V1.25.0

Host OS and its Version

No response

Steps to reproduce

  1. run k8sgpt integration activate trivy —no-install
  2. run k8sgpt integration list

Trivy will still be deactivated.

I think it is due to the fact that the isActivated method checks if the trivy helm chart is installed:

func (t *Trivy) IsActivate() bool {

When trivy is installed via ArgoCD this will always be false …

Expected behaviour

K8sGPT should use a different check to find out if trivy integration is activated

Actual behaviour

K8sGPT shows the wrong state of trivy integration

Additional Information

No response

@AlexsJones
Copy link
Member

This certainly is something that needs an improvement - rather than looking for the helm deployment we should check some other marker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants