Customize Grafana annotation and label #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
AlexsJones
approved these changes
May 17, 2023
AlexsJones
reviewed
May 17, 2023
| annotation: grafana_folder | ||
| name: ai | ||
| dashboard: | ||
| label: grafana_dashboard |
There was a problem hiding this comment.
Is there ever a time this wouldn't be set grafana_dashboard ? Isn't that the default grafana searches for?
There was a problem hiding this comment.
yes it's the default. But it could be customizable https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml#L853
AlexsJones
reviewed
May 17, 2023
2 tasks
AlexsJones
added a commit
that referenced
this pull request
May 18, 2023
This reverts commit 089b2dd.
AlexsJones
added a commit
that referenced
this pull request
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
Grafana sidecar load dashboards using an annotation and a label. These annotation and label are customizable.
This PR add this feature.
✅ Checks
ℹ Additional Information