feat: add caching client #129
Conversation
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
| @@ -199,7 +206,15 @@ func (r *K8sGPTReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| r.k8sGPTClients[k8sgptConfig.Name] = k8sgptClient | |||
| } | |||
|
|
|||
| response, err := r.k8sGPTClients[k8sgptConfig.Name].ProcessAnalysis(deployment, k8sgptConfig) | |||
| if k8sgptConfig.Spec.RemoteCache != nil { | |||
There was a problem hiding this comment.
This needs to be called once and only once right? Or do you think we should be updating the config pre-analysis? It might be a good thing I suppose
There was a problem hiding this comment.
Good point, I think it's necessary to call it in two cases: when the object is created and when it's modified. What do you think ?
There was a problem hiding this comment.
If you want to call this on object creation, call it further up before the finalizer is created
| ) | ||
| } | ||
| addRemoteCacheEnvVar("AWS_ACCESS_KEY_ID", config.Spec.RemoteCache.Credentials.AccessKeyID) | ||
| addRemoteCacheEnvVar("AWS_SECRET_ACCESS_KEY", config.Spec.RemoteCache.Credentials.SecretAccessKey) |
There was a problem hiding this comment.
I am confused by this and by the new CredentialsRef type,
This should:
// Check to see if that secret exists ( missing)
// Unwrap the secret literal values ( missing )
// Mount each value as an EnvVarSecret ( done )
There was a problem hiding this comment.
In my opinion, to be consistent with the rest of the code, it is necessary to check this: config.Spec.RemoteCache.Credentials != nil. As for the secret related to the OpenAI credentials, it seems to me that we are not checking the presence of the secret itself, but rather the configuration. Am I mistaken?
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
|
LMK when to review again! |
|
just curious, will this change restore compatibility with later versions (newer than 0.3.4) of k8sgpt? |
|
I have updated this PR here @matthisholleville #201 |
Closes #113
📑 Description
This pull request is intended to implement the remote cache feature in the operator. This feature enables users to utilize a remote cache via an S3 bucket.
Modifications have been made to the client's structure in order to separate the different client methods into multiple files. Additionally, an implementation example has been added to the README.
✅ Checks
ℹ Additional Information