Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added llm metric analysis count #290

Merged
merged 3 commits into from
Dec 11, 2023
Merged

feat: added llm metric analysis count #290

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf1143d
feat: added llm metric analysis count
AlexsJones Dec 8, 2023
3d6c588
feat: added llm metric analysis count
AlexsJones Dec 8, 2023
275e9b2
feat: added llm metric analysis count
AlexsJones Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 29 additions & 2 deletions controllers/k8sgpt_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ var (
Name: "k8sgpt_number_of_results_by_type",
Help: "The total number of results by type",
}, []string{"kind", "name"})
// k8sgptNumberOfBackendAICalls is a metric for the number of backend AI calls
k8sgptNumberOfBackendAICalls = prometheus.NewCounterVec(prometheus.CounterOpts{
Name: "k8sgpt_number_of_backend_ai_calls",
Help: "The total number of backend AI calls",
}, []string{"backend", "deployment", "namespace"})
// k8sNumberOfFailedBackendAICalls is a metric for the number of failed backend AI calls
k8sgptNumberOfFailedBackendAICalls = prometheus.NewCounterVec(prometheus.CounterOpts{
Name: "k8sgpt_number_of_failed_backend_ai_calls",
Help: "The total number of failed backend AI calls",
}, []string{"backend", "deployment", "namespace"})
)

// K8sGPTReconciler reconciles a K8sGPT object
Expand Down Expand Up @@ -158,7 +168,7 @@ func (r *K8sGPTReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
return r.finishReconcile(nil, false)
}

// If the deployment is active, we will query it directly for analysis data
// If the deployment is active, we will query it directly for sis data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexsJones i guess this is typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes well caught

address, err := kclient.GenerateAddress(ctx, r.Client, k8sgptConfig)
if err != nil {
k8sgptReconcileErrorCount.Inc()
Expand Down Expand Up @@ -193,9 +203,23 @@ func (r *K8sGPTReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr

response, err := k8sgptClient.ProcessAnalysis(deployment, k8sgptConfig)
if err != nil {
if k8sgptConfig.Spec.AI.Enabled {
k8sgptNumberOfFailedBackendAICalls.With(prometheus.Labels{
"backend": k8sgptConfig.Spec.AI.Backend,
"deployment": deployment.Name,
"namespace": deployment.Namespace}).Inc()
}
k8sgptReconcileErrorCount.Inc()
return r.finishReconcile(err, false)
}
// Update metrics count
if k8sgptConfig.Spec.AI.Enabled {
k8sgptNumberOfBackendAICalls.With(prometheus.Labels{
"backend": k8sgptConfig.Spec.AI.Backend,
"deployment": deployment.Name,
"namespace": deployment.Namespace}).Inc()
}

// Parse the k8sgpt-deployment response into a list of results
k8sgptNumberOfResults.Set(float64(len(response.Results)))
rawResults, err := resources.MapResults(*r.Integrations, response.Results, *k8sgptConfig)
Expand Down Expand Up @@ -302,7 +326,10 @@ func (r *K8sGPTReconciler) SetupWithManager(mgr ctrl.Manager) error {
For(&corev1alpha1.K8sGPT{}).
Complete(r)

metrics.Registry.MustRegister(k8sgptReconcileErrorCount, k8sgptNumberOfResults, k8sgptNumberOfResultsByType)
metrics.Registry.MustRegister(k8sgptReconcileErrorCount,
k8sgptNumberOfResults,
k8sgptNumberOfResultsByType,
k8sgptNumberOfBackendAICalls, k8sgptNumberOfFailedBackendAICalls)

return c
}
Expand Down