Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: specify namespace on k8sgpt crd #291

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

singhiqbal1007
Copy link
Contributor

@singhiqbal1007 singhiqbal1007 commented Dec 10, 2023

Closes #270

πŸ“‘ Description

  • added namespace selector on k8sgpt
  • added namespace argument on grpc request

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Tested these changes on my local machine.
targetNamespace field is optional. If given then it looks for issues only in the given namespaces otherwise It looks for issues in all the namespaces.

@JuHyung-Son
Copy link
Contributor

thanks for pr.
helm charts crd definition is not generating automatically. so you should manually add field in chart/operator/templates/k8sgpt-crd.yaml

@singhiqbal1007 singhiqbal1007 changed the title specify namespace on k8sgpt crd feat: specify namespace on k8sgpt crd Dec 10, 2023
pkg/client/analysis.go Show resolved Hide resolved
Signed-off-by: Iqbal Singh <singhiqbal1007@gmail.com>
Signed-off-by: Iqbal Singh <singhiqbal1007@gmail.com>
@singhiqbal1007
Copy link
Contributor Author

@arbreezy Resolved the conflicts.

@arbreezy arbreezy merged commit 6492cce into k8sgpt-ai:main Jan 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: specify namespace on k8sgpt crd
3 participants