Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: generate results in the target namespace #399

Merged
merged 2 commits into from
Apr 19, 2024
Merged

feature: generate results in the target namespace #399

merged 2 commits into from
Apr 19, 2024

Conversation

VaibhavMalik4187
Copy link
Contributor

📑 Description

Now, the result crd will be generated in the target namespace instead of k8sgpt config namespace.

Addresses: #390

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@VaibhavMalik4187
feature: generate results in the target namespace
308e5f8 
Now, the result crd will be generated in the target namespace instead of
k8sgpt config namespace.

Addresses: k8sgpt-ai#390

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
@VaibhavMalik4187 VaibhavMalik4187 requested review from a team as code owners April 2, 2024 16:23
@AlexsJones AlexsJones merged commit bd14c1a into k8sgpt-ai:main Apr 19, 2024
6 checks passed
MateSousa pushed a commit to MateSousa/k8sgpt-operator that referenced this pull request May 2, 2024
@VaibhavMalik4187 @arbreezy @MateSousa
feature: generate results in the target namespace (k8sgpt-ai#399)
91b1692 
Now, the result crd will be generated in the target namespace instead of
k8sgpt config namespace.

Addresses: k8sgpt-ai#390

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
Co-authored-by: Aris Boutselis <arisboutselis08@gmail.com>
Signed-off-by: Matheus Sousa <matessousa@outlook.com>
@JuHyung-Son JuHyung-Son mentioned this pull request May 21, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

@lavishpal lavishpal lavishpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VaibhavMalik4187 @AlexsJones @lavishpal @arbreezy