feat/custom analysis #474
feat/custom analysis #474
Conversation
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
| @@ -54,9 +67,10 @@ func (c *Client) AddConfig(config *v1alpha1.K8sGPT) error { | |||
|
|
|||
| func (c *Client) RemoveConfig(config *v1alpha1.K8sGPT) error { | |||
There was a problem hiding this comment.
Does this function actually work?
RemoveConfigRequest is actually an empty value.
There was a problem hiding this comment.
RemoveConfig is actually only related to removing the cache configuration, frankly speaking the whole config API that we have created needs better structuring as it has grown organically including different functionality
It works by removing whatever is configured in the k8sgpt's configuration cache stanza..
So neither integrations nor now the customanalyzers will be deleted with removeConfig()
There was a problem hiding this comment.
Yeah we were just discussing doing a refactor of the config stuff in slack
|
We also have to add the new crd schema to the helm templates and there are some conflicts |
Signed-off-by: AlexsJones <alexsimonjones@gmail.com>
* chore: updated the spec Signed-off-by: Alex Jones <alexsimonjones@gmail.com> * feat: add custom analyzers into the k8sgpt config Signed-off-by: Alex Jones <alexsimonjones@gmail.com> * feat: add custom analyzers into the k8sgpt config Signed-off-by: Alex Jones <alexsimonjones@gmail.com> * feat: add custom analyzers into the k8sgpt config Signed-off-by: Alex Jones <alexsimonjones@gmail.com> * chore: fixed the reconcile not picking up custom analyzers Signed-off-by: Alex Jones <alexsimonjones@gmail.com> --------- Signed-off-by: Alex Jones <alexsimonjones@gmail.com> Signed-off-by: AlexsJones <alexsimonjones@gmail.com> Signed-off-by: Ronald Petty <ronald.petty@rx-m.com>
Closes #
📑 Description
✅ Checks
ℹ Additional Information