Skip to content

Commit

Permalink
feat: rename cache methods
Browse files Browse the repository at this point in the history
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
  • Loading branch information
matthisholleville committed May 25, 2023
1 parent 6bc94b8 commit 470ea99
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion cmd/cache/add.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var addCmd = &cobra.Command{
- S3`,
Run: func(cmd *cobra.Command, args []string) {
fmt.Println(color.YellowString("Adding remote S3 based cache"))
err := cache.AddCache(bucketname, region)
err := cache.AddRemoteCache(bucketname, region)
if err != nil {
color.Red("Error: %v", err)
os.Exit(1)
Expand Down
4 changes: 2 additions & 2 deletions pkg/cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func RemoteCacheEnabled() (bool, error) {
return false, nil
}

func AddCache(bucketName string, region string) error {
func AddRemoteCache(bucketName string, region string) error {
var cacheInfo CacheProvider
err := viper.UnmarshalKey("cache", &cacheInfo)
if err != nil {
Expand All @@ -61,7 +61,7 @@ func AddCache(bucketName string, region string) error {
return nil
}

func RemoveCache(bucketName string) error {
func RemoveRemoteCache(bucketName string) error {
var cacheInfo CacheProvider
err := viper.UnmarshalKey("cache", &cacheInfo)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions pkg/server/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func (h *handler) AddConfig(ctx context.Context, i *schemav1.AddConfigRequest) (
return nil, errors.New("BucketName & Region are required")
}

err := cache.AddCache(i.Cache.BucketName, i.Cache.Region)
err := cache.AddRemoteCache(i.Cache.BucketName, i.Cache.Region)
if err != nil {
return &schemav1.AddConfigResponse{}, err
}
Expand All @@ -26,7 +26,7 @@ func (h *handler) AddConfig(ctx context.Context, i *schemav1.AddConfigRequest) (

func (h *handler) RemoveConfig(ctx context.Context, i *schemav1.RemoveConfigRequest) (*schemav1.RemoveConfigResponse, error,
) {
err := cache.RemoveCache(i.Cache.BucketName)
err := cache.RemoveRemoteCache(i.Cache.BucketName)
if err != nil {
return &schemav1.RemoveConfigResponse{}, err
}
Expand Down

0 comments on commit 470ea99

Please sign in to comment.