chore: updating based on feedback

Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
k8sgpt-ai · Apr 11, 2023 · 5e5d4b6 · 5e5d4b6
1 parent 34e3e39
commit 5e5d4b6
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 15 deletions.
diff --git a/cmd/filters/add.go b/cmd/filters/add.go
@@ -20,9 +20,7 @@ var addCmd = &cobra.Command{
 		inputFilters := strings.Split(args[0], ",")
 		coreFilters, additionalFilters, integrationFilters := analyzer.ListFilters()
 
-		availableFilters := append(coreFilters, additionalFilters...)
-		availableFilters = append(availableFilters, integrationFilters...)
-
+		availableFilters := append(append(coreFilters, additionalFilters...), integrationFilters...)
 		// Verify filter exist
 		invalidFilters := []string{}
 		for _, f := range inputFilters {

diff --git a/cmd/filters/list.go b/cmd/filters/list.go
@@ -18,8 +18,8 @@ var listCmd = &cobra.Command{
 		activeFilters := viper.GetStringSlice("active_filters")
 		coreFilters, additionalFilters, integrationFilters := analyzer.ListFilters()
 
-		availableFilters := append(coreFilters, additionalFilters...)
-		availableFilters = append(availableFilters, integrationFilters...)
+		availableFilters := append(append(coreFilters, additionalFilters...), integrationFilters...)
+
 		if len(activeFilters) == 0 {
 			activeFilters = coreFilters
 		}

diff --git a/cmd/integration/activate.go b/cmd/integration/activate.go
@@ -13,17 +13,17 @@ var activateCmd = &cobra.Command{
 	Long:  ``,
 	Args:  cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
-		intName := args[0]
+		integrationName := args[0]
 
 		integration := integration.NewIntegration()
 		// Check if the integation exists
-		err := integration.Activate(intName, namespace)
+		err := integration.Activate(integrationName, namespace)
 		if err != nil {
 			color.Red("Error: %v", err)
 			return
 		}
 
-		color.Green("Activated integration %s", intName)
+		color.Green("Activated integration %s", integrationName)
 	},
 }
 

diff --git a/cmd/integration/deactivate.go b/cmd/integration/deactivate.go
@@ -16,16 +16,16 @@ var deactivateCmd = &cobra.Command{
 	Args:  cobra.ExactArgs(1),
 	Long:  `For example e.g. k8sgpt integration deactivate trivy`,
 	Run: func(cmd *cobra.Command, args []string) {
-		intName := args[0]
+		integrationName := args[0]
 
 		integration := integration.NewIntegration()
 
-		if err := integration.Deactivate(intName, namespace); err != nil {
+		if err := integration.Deactivate(integrationName, namespace); err != nil {
 			color.Red("Error: %v", err)
 			return
 		}
 
-		color.Green("Deactivated integration %s", intName)
+		color.Green("Deactivated integration %s", integrationName)
 
 	},
 }

diff --git a/cmd/integration/list.go b/cmd/integration/list.go
@@ -15,12 +15,12 @@ var listCmd = &cobra.Command{
 	Short: "Lists built-in integrations",
 	Long:  ``,
 	Run: func(cmd *cobra.Command, args []string) {
-		integration := integration.NewIntegration()
-		integrations := integration.List()
+		integrationProvider := integration.NewIntegration()
+		integrations := integrationProvider.List()
 
 		fmt.Println(color.YellowString("Active:"))
 		for _, i := range integrations {
-			b, err := integration.IsActivate(i)
+			b, err := integrationProvider.IsActivate(i)
 			if err != nil {
 				fmt.Println(err)
 				os.Exit(1)
@@ -32,7 +32,7 @@ var listCmd = &cobra.Command{
 
 		fmt.Println(color.YellowString("Unused: "))
 		for _, i := range integrations {
-			b, err := integration.IsActivate(i)
+			b, err := integrationProvider.IsActivate(i)
 			if err != nil {
 				fmt.Println(err)
 				os.Exit(1)