fix: defer to service analyser when selectors are missing (#652)

Signed-off-by: Aris Boutselis <arisboutselis08@gmail.com> Co-authored-by: Aris Boutselis <arisboutselis08@gmail.com> Co-authored-by: Alex Jones <alexsimonjones@gmail.com>
k8sgpt-ai · Sep 14, 2023 · 6c5a062 · 6c5a062
1 parent 598ef22
commit 6c5a062
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/pkg/analyzer/mutating_webhook.go b/pkg/analyzer/mutating_webhook.go
@@ -78,6 +78,10 @@ func (MutatingWebhookAnalyzer) Analyze(a common.Analyzer) ([]common.Result, erro
 				continue
 			}
 
+			// When Service selectors are empty we defer to service analyser
+			if len(service.Spec.Selector) == 0 {
+				continue
+			}
 			// Get pods within service
 			pods, err := a.Client.GetClient().CoreV1().Pods(svc.Namespace).List(context.Background(), v1.ListOptions{
 				LabelSelector: util.MapToString(service.Spec.Selector),

diff --git a/pkg/analyzer/validating_webhook.go b/pkg/analyzer/validating_webhook.go
@@ -76,6 +76,10 @@ func (ValidatingWebhookAnalyzer) Analyze(a common.Analyzer) ([]common.Result, er
 				continue
 			}
 
+			// When Service selectors are empty we defer to service analyser
+			if len(service.Spec.Selector) == 0 {
+				continue
+			}
 			// Get pods within service
 			pods, err := a.Client.GetClient().CoreV1().Pods(svc.Namespace).List(context.Background(), v1.ListOptions{
 				LabelSelector: util.MapToString(service.Spec.Selector),