Skip to content

Commit

Permalink
fix: fixed hpa tests after rebase
Browse files Browse the repository at this point in the history
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
  • Loading branch information
matthisholleville committed Apr 5, 2023
1 parent 8958a45 commit a24d1f1
Showing 1 changed file with 40 additions and 40 deletions.
80 changes: 40 additions & 40 deletions pkg/analyzer/hpaAnalyzer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ func TestHPAAnalyzer(t *testing.T) {
},
})
hpaAnalyzer := HpaAnalyzer{}
var analysisResults []Analysis
err := hpaAnalyzer.RunAnalysis(context.Background(),
&AnalysisConfiguration{
Namespace: "default",
},
&kubernetes.Client{
config := Analyzer{
Client: &kubernetes.Client{
Client: clientset,
}, nil, &analysisResults)
},
Context: context.Background(),
Namespace: "default",
}
analysisResults, err := hpaAnalyzer.Analyze(config)
if err != nil {
t.Fatalf("unexpected error: %v", err)
t.Error(err)
}
assert.Equal(t, len(analysisResults), 1)
}
Expand All @@ -55,16 +55,16 @@ func TestHPAAnalyzerWithMultipleHPA(t *testing.T) {
},
)
hpaAnalyzer := HpaAnalyzer{}
var analysisResults []Analysis
err := hpaAnalyzer.RunAnalysis(context.Background(),
&AnalysisConfiguration{
Namespace: "default",
},
&kubernetes.Client{
config := Analyzer{
Client: &kubernetes.Client{
Client: clientset,
}, nil, &analysisResults)
},
Context: context.Background(),
Namespace: "default",
}
analysisResults, err := hpaAnalyzer.Analyze(config)
if err != nil {
t.Fatalf("unexpected error: %v", err)
t.Error(err)
}
assert.Equal(t, len(analysisResults), 2)
}
Expand All @@ -86,16 +86,16 @@ func TestHPAAnalyzerWithUnsuportedScaleTargetRef(t *testing.T) {
})
hpaAnalyzer := HpaAnalyzer{}

var analysisResults []Analysis
err := hpaAnalyzer.RunAnalysis(context.Background(),
&AnalysisConfiguration{
Namespace: "default",
},
&kubernetes.Client{
config := Analyzer{
Client: &kubernetes.Client{
Client: clientset,
}, nil, &analysisResults)
},
Context: context.Background(),
Namespace: "default",
}
analysisResults, err := hpaAnalyzer.Analyze(config)
if err != nil {
t.Fatalf("unexpected error: %v", err)
t.Error(err)
}

var errorFound bool
Expand Down Expand Up @@ -133,16 +133,16 @@ func TestHPAAnalyzerWithUnexistentScaleTargetRef(t *testing.T) {
})
hpaAnalyzer := HpaAnalyzer{}

var analysisResults []Analysis
err := hpaAnalyzer.RunAnalysis(context.Background(),
&AnalysisConfiguration{
Namespace: "default",
},
&kubernetes.Client{
config := Analyzer{
Client: &kubernetes.Client{
Client: clientset,
}, nil, &analysisResults)
},
Context: context.Background(),
Namespace: "default",
}
analysisResults, err := hpaAnalyzer.Analyze(config)
if err != nil {
t.Fatalf("unexpected error: %v", err)
t.Error(err)
}

var errorFound bool
Expand Down Expand Up @@ -188,16 +188,16 @@ func TestHPAAnalyzerWithExistingScaleTargetRef(t *testing.T) {
)
hpaAnalyzer := HpaAnalyzer{}

var analysisResults []Analysis
err := hpaAnalyzer.RunAnalysis(context.Background(),
&AnalysisConfiguration{
Namespace: "default",
},
&kubernetes.Client{
config := Analyzer{
Client: &kubernetes.Client{
Client: clientset,
}, nil, &analysisResults)
},
Context: context.Background(),
Namespace: "default",
}
analysisResults, err := hpaAnalyzer.Analyze(config)
if err != nil {
t.Fatalf("unexpected error: %v", err)
t.Error(err)
}
for _, analysis := range analysisResults {
assert.Equal(t, len(analysis.Error), 0)
Expand Down

0 comments on commit a24d1f1

Please sign in to comment.