Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix mistake introduced by ab55f157 #240

Merged
merged 1 commit into from
Apr 10, 2023
Merged

fix: fix mistake introduced by ab55f157 #240

merged 1 commit into from
Apr 10, 2023

Conversation

thomasstxyz
Copy link
Contributor

@thomasstxyz thomasstxyz commented Apr 10, 2023 •
edited
Loading

📑 Description

fix bug introduced by mistake via ab55f15 PR #237

ensure output is json

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@thomasstxyz
chore: fix mistake introduced by ab55f15
cfe2085 
Signed-off-by: Thomas Stadler <thomas@thomasst.xyz>
@thomasstxyz thomasstxyz requested review from a team as code owners April 10, 2023 19:57
@thomasstxyz thomasstxyz changed the title chore: fix mistake introduced by ab55f157 fix: fix mistake introduced by ab55f157 Apr 10, 2023
thschue
thschue approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 3845d47 into k8sgpt-ai:main Apr 10, 2023
@github-actions github-actions bot mentioned this pull request Apr 10, 2023
Merged
AlexsJones pushed a commit that referenced this pull request Apr 11, 2023
@thomasstxyz @AlexsJones
chore: fix mistake introduced by ab55f15 (#240)
428c348 
Signed-off-by: Thomas Stadler <thomas@thomasst.xyz>
Signed-off-by: Alex Jones <alexsimonjones@gmail.com>
@thomasstxyz thomasstxyz deleted the fix/missing-newline-after-progressbar branch April 30, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thschue thschue thschue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasstxyz @thschue