Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit progressbar on error to fix missing newline #237

Merged
merged 1 commit into from
Apr 10, 2023
Merged

fix: exit progressbar on error to fix missing newline #237

merged 1 commit into from
Apr 10, 2023
+5 −6

Conversation

thomasstxyz
Copy link
Contributor

@thomasstxyz thomasstxyz commented Apr 10, 2023 •
edited

Closes #99

📑 Description

Properly exit the progressbar on error to avoid the missing newline mentioned in issue #99.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@thomasstxyz
fix: exit progressbar on error (k8sgpt-ai#99)
ab55f15 
Signed-off-by: Thomas Stadler <thomas@thomasst.xyz>
@thomasstxyz thomasstxyz requested a review from a team as a code owner April 10, 2023 18:16
@AlexsJones AlexsJones merged commit 63dccdb into k8sgpt-ai:main Apr 10, 2023
@thomasstxyz thomasstxyz mentioned this pull request Apr 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing newline after progress bar
2 participants
@thomasstxyz @AlexsJones