Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve HPA analyzer to check ScaleTargetRef resources #283

Merged
merged 9 commits into from
Apr 18, 2023
Merged

feat: improve HPA analyzer to check ScaleTargetRef resources #283

merged 9 commits into from
Apr 18, 2023

Conversation

rakshitgondwal
Copy link
Member

Closes #261

📑 Description

  • Modified hpa.go to check if the ScaleTargetRef has resource configured.
  • Modified hpaAnalyzer_test.go to update the test cases to include the Resources.Requests and Resource.Limits.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@rakshitgondwal
feat: improve HPA analyzer to check ScaleTargetRef resources
d1a8931 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal
feat: modify tests
62e3fb0 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal rakshitgondwal requested review from a team as code owners April 15, 2023 18:08
rakshitgondwal and others added 3 commits April 17, 2023 17:41
@rakshitgondwal
Merge branch 'k8sgpt-ai:main' into dev
0ceed62
@rakshitgondwal
feat: improve all ScaleTargetRef to check for resources
3150b1b 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@rakshitgondwal
test: add test cases for all ScaleTargetRef types
fc62ac6 
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@matthisholleville @rakshitgondwal
refactor: use interface to avoid dupplication
af06ef1 
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
@matthisholleville
Copy link
Contributor

Good job @rakshitgondwal ! lgtm

@AlexsJones AlexsJones merged commit 7173203 into k8sgpt-ai:main Apr 18, 2023
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Merged
@rakshitgondwal
Copy link
Member Author

Thank you for the merge!

@rakshitgondwal rakshitgondwal mentioned this pull request Jun 2, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthisholleville matthisholleville matthisholleville left review comments

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: improve HPA analyzer to check if ScaleTargetRef have ressources configured
3 participants
@rakshitgondwal @matthisholleville @AlexsJones