feature: Add linter to PR build pipeline #330
Comments
|
Please assign the issue to me 🙂 |
patrickpichler
pushed a commit
to patrickpichler/k8sgpt
that referenced
this issue
Apr 25, 2023
In order to catch a variaty of small and quick to happen mistakes, there is now an additional action in place which runs a linter on the PR content. fixes k8sgpt-ai#330
4 tasks
patrickpichler
pushed a commit
to patrickpichler/k8sgpt
that referenced
this issue
Apr 25, 2023
In order to catch a variaty of small and quick to happen mistakes, there is now an additional action in place which runs a linter on the PR content. fixes k8sgpt-ai#330 Signed-off-by: Patrick Pichler <git@patrickpichler.dev>
AlexsJones
pushed a commit
that referenced
this issue
Apr 25, 2023
In order to catch a variaty of small and quick to happen mistakes, there is now an additional action in place which runs a linter on the PR content. fixes #330 Signed-off-by: Patrick Pichler <git@patrickpichler.dev> Co-authored-by: Patrick Pichler <git@patrickpichler.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist:
Is this feature request related to a problem?
There are a few subtle bugs introduced to the main branch, which could have been prevented
by letting a linter run before merging PRs.
Describe the solution you'd like
A own workflow for running a linter such as golangci-lint should be introduced,
which runs for PRs. This should catch a large amount of easy to avoid issues.
Benefits for the project and its users
Less easy to avoid bugs, as already caught in an automated way in the PR.
Potential drawbacks
There could be some false-positive findings by the linter, which would end up in some noise on the PR.
Additional context
The text was updated successfully, but these errors were encountered: