-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] After integration activate
, k8sgpt analyze
will never run the Core Analyzers.
#412
Comments
Hi, @matthisholleville @AlexsJones , Let's discuss here ( previously our discuss thread was in the PR #413)? I change the issue description and title, to be more accurate. I was thingking this issue is relevant to #431 and can be fixed by #432 . But it's NOT. I think they are different issues. people can try my steps, it's very easy to reproduce. |
integration activate
, k8sgpt analyze
will never run the Core Analyzers.
Unless I'm mistaken, this behavior is actually intended. The integration takes over the classical analyzers. There is nothing to prevent it from evolving but I don't think it's a bug. What do you think about it @AlexsJones ? |
in my mind as a user, integration is like an additional plugin ? not aim to replace but replenish ? |
Should it be explicit and let the user know what will happen before proceeding? is it possible to easily revert? |
Checklist
Affected Components
K8sGPT Version
v0.3.2
Kubernetes Version
v1.25.4
Host OS and its Version
Ubuntu
Steps to reproduce
Detail reproduce steps with 0.3.2.
(1) before integration, everything is fine.
# k8sgpt filter list
(2) activate trivy
# k8sgpt integration activate trivy
(3) Now, ALL others are REMOVED from Active filter list,
ONLY Trivy left !! (I believe it's unexpected and the root cause )
I think the expected behavior is adding VulnerabilityReport into the original Active List instead of exclude them all.
# k8sgpt filter list
(4)
k8sgpt analyze
ONLY shows Trivy reports !!# k8sgpt analyze
Expected behaviour
Even there's active integration ,
k8sgpt analyze
should include all built-in analyzer instead of only activated trivy.Actual behaviour
as above.
Additional Information
No response
The text was updated successfully, but these errors were encountered: