-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: run all analyzer when no --filter given #413
Conversation
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Active filters are set in a file, by removing this check those settings will be ignored. |
I think the check will done in https://github.com/k8sgpt-ai/k8sgpt/blob/main/pkg/analysis/analysis.go#L192 by |
Exactly, @AlexsJones. This is incorrect because we would only run all filters if "--filter" is not set and the "active_filters" in the configuration file are empty. |
@matthisholleville @AlexsJones . my understanding of the UX design is as below, but seems it's not. Do you consider the way about below ?
|
When you do this, you should be able to run The filters should also show something like this
If that is not working currently then there is a bug. I am not really following what the issue is here. It's completely possible for |
Yes, it's a bug, Alex. @AlexsJones Detail reproduce steps with 0.3.2. (1) before integration, everything is fine.
(2) activate trivy
(3) ALL others are REMOVED from Active filter list, ONLY Trivy left (I believe it's unexpected and the root cause )
(4)
|
I think the problem actually in
The best I can figure out to fix the problem is below
But it will introduce complier error of |
move the discussion to issue #412 |
close it , #441 has fixed it |
Closes #412
π Description
refer to the #412
β Checks
Before fixing:
Test Result with newly complied binary:
βΉ Additional Information