fix: use status instead of event for pdb checking #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexsJones
reviewed
Jun 2, 2023
arbreezy
requested changes
Jun 4, 2023
jianzhangbjz
changed the title
AlexsJones
approved these changes
Jun 5, 2023
Hi @AlexsJones @arbreezy , thanks for your review. I will squash those two commits, but, sorry, what commit message I should add? Thanks! |
The PDB event is a historical record, it's not a good choice to judge the pdb latest status based on it. So, use the `stataus` instead of `event` to check it. Closes: k8sgpt-ai#476 Signed-off-by: Jian Zhang <jiazha@redhat.com>
|
Hi @AlexsJones @AlexsJones , I updated the commit message, please let me know if any thing else is needed, thanks! fix: use the `status` for pdb checking
The PDB event is a historical record, it's not a good choice to judge the pdb latest status based on it.
So, use the `stataus` instead of `event` to check it.
Closes: #476
Signed-off-by: Jian Zhang <jiazha@redhat.com> |
arbreezy
approved these changes
Jun 6, 2023
|
Hi @AlexsJones @arbreezy, seems like the merging is blocked by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476
📑 Description
The PDB event is a historical record, it's not a good choice to judge
pdbstatus by based on it. So, I used thestatusinstead ofeventin this PR.✅ Checks
ℹ Additional Information