-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use status instead of event for pdb checking #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update your commit message as well, to conform with release-please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but as @arbreezy says please update commit message
Hi @AlexsJones @arbreezy , thanks for your review. I will squash those two commits, but, sorry, what commit message I should add? Thanks! |
The PDB event is a historical record, it's not a good choice to judge the pdb latest status based on it. So, use the `stataus` instead of `event` to check it. Closes: k8sgpt-ai#476 Signed-off-by: Jian Zhang <jiazha@redhat.com>
Hi @AlexsJones @AlexsJones , I updated the commit message, please let me know if any thing else is needed, thanks! fix: use the `status` for pdb checking
The PDB event is a historical record, it's not a good choice to judge the pdb latest status based on it.
So, use the `stataus` instead of `event` to check it.
Closes: #476
Signed-off-by: Jian Zhang <jiazha@redhat.com> |
Hi @AlexsJones @arbreezy, seems like the merging is blocked by |
Closes #476
π Description
The PDB event is a historical record, it's not a good choice to judge
pdb
status by based on it. So, I used thestatus
instead ofevent
in this PR.β Checks
βΉ Additional Information