Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Integration --no-install option #534

Closed
2 tasks done
AlexsJones opened this issue Jun 29, 2023 · 1 comment · Fixed by #536
Closed
2 tasks done

[Feature]: Integration --no-install option #534

AlexsJones opened this issue Jun 29, 2023 · 1 comment · Fixed by #536
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AlexsJones
Copy link
Member

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

No

Problem Description

No response

Solution Description

With the trivy integration, we assume we will install a trivy operator release.
There should be a --no-install mode to just activate the analyser without installing the release

Benefits

Fits into an existing infrastructure stack

Potential Drawbacks

No response

Additional Information

No response
@AlexsJones AlexsJones added enhancement New feature or request good first issue Good for newcomers labels Jun 29, 2023
@panpan0000
Copy link
Contributor

panpan0000 commented Jun 30, 2023 •
edited

Can I ?
although not a first time contributor, but it's a shame after long time silence, just try to help something..

@panpan0000 panpan0000 mentioned this issue Jun 30, 2023
Merged
2 tasks
panpan0000 added a commit to panpan0000/k8sgpt that referenced this issue Jun 30, 2023
@panpan0000
Fix: add --no-install for activate command
1d1ae1f 
to fix k8sgpt-ai#534

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
panpan0000 added a commit to panpan0000/k8sgpt that referenced this issue Jun 30, 2023
@panpan0000
fix: add --no-install for activate command
6b918b8 
to fix k8sgpt-ai#534

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
AlexsJones pushed a commit that referenced this issue Jul 3, 2023
@panpan0000
fix: add --no-install for activate command (#536)
1f5462c 
to fix #534

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add --no-install for activate command panpan0000/k8sgpt
2 participants
@AlexsJones @panpan0000