Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --no-install for activate command #536

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

panpan0000
Copy link
Contributor

@panpan0000 panpan0000 commented Jun 30, 2023

Closes #534

Use Case:
This flag is helpful, for example, I ran k8sgpt command in local machine, but the k8s cluster runs remotely.
I've activated the plugin remotely, but local k8sgpt.conf didn't reflect it.
so this flag helps my local config file to catch up the real situation.

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • [] My code requires changes to the documentation
  • [] I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Demo :

(1) Before activate trivy:
image

(2) helper message:
image

(3) activate without install it
image

@panpan0000 panpan0000 requested review from a team as code owners June 30, 2023 02:46
@panpan0000 panpan0000 changed the title Fix#534: add --no-install for activate command fix: add --no-install for activate command Jun 30, 2023
to fix k8sgpt-ai#534

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
@AlexsJones
Copy link
Member

I love all the detailed photos, thanks!

@AlexsJones AlexsJones merged commit 1f5462c into k8sgpt-ai:main Jul 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Integration --no-install option
2 participants