Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix readme for anonymization #559

Merged
merged 10 commits into from
Jul 19, 2023
Merged

docs: fix readme for anonymization #559

merged 10 commits into from
Jul 19, 2023

Conversation

jatinmehrotra
Copy link
Contributor

@jatinmehrotra jatinmehrotra commented Jul 18, 2023 •
edited
Loading

Closes #

📑 Description

  • Fixed Broken Markdown for Anonymization section in readme.md
  • Updated details for the events where anonymization does not apply in readme.md

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@jatinmehrotra jatinmehrotra requested review from a team as code owners July 18, 2023 02:08
@jatinmehrotra jatinmehrotra changed the title Fix readme for anonymization docs: Fix readme for anonymization Jul 18, 2023
@jatinmehrotra jatinmehrotra changed the title docs: Fix readme for anonymization docs: fix readme for anonymization Jul 18, 2023
@jatinmehrotra
Copy link
Contributor Author

jatinmehrotra commented Jul 18, 2023 •
edited
Loading

@AlexsJones

Here is the PR from #541

Please feel free to mention me if there is any correction needed.

AlexsJones
AlexsJones requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@AlexsJones AlexsJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @jatinmehrotra I have made a few suggestions on pinning to the issue

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Jatin Mehrotra added 5 commits July 19, 2023 07:27
docs: fixed markdown for Anonymization
1317a4b 
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
docs: added details for events which are not being masked
2f006dd 
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
docs: removed timeframe, added issue link for event anonymization
59efe6d 
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
docs: changed title to Further details
93ca483 
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
docs: fixed broken markdown for config management and remote caching …
5bf7e92 
…section

Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
@jatinmehrotra
Copy link
Contributor Author

@AlexsJones

Thank you for your review. I have pushed commits with regard to your requested changes.

I noticed another broken markdown so I have pushed commit 5bf7e92. Just to let you know this commit was not there in the initial review. Please consider this commit 5bf7e92 too in your review.

Jatin Mehrotra added 2 commits July 19, 2023 09:05
AlexsJones
AlexsJones reviewed Jul 19, 2023
View reviewed changes
README.md Show resolved Hide resolved
AlexsJones
AlexsJones reviewed Jul 19, 2023
View reviewed changes
README.md Show resolved Hide resolved
@AlexsJones AlexsJones merged commit 70bec05 into k8sgpt-ai:main Jul 19, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jatinmehrotra @AlexsJones