-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix readme for anonymization #559
Merged
AlexsJones
merged 10 commits into
k8sgpt-ai:main
from
jatinmehrotra:fix-readme-for-anonymization
Jul 19, 2023
Merged
docs: fix readme for anonymization #559
AlexsJones
merged 10 commits into
k8sgpt-ai:main
from
jatinmehrotra:fix-readme-for-anonymization
Jul 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b457cf9
to
87184ad
Compare
Here is the PR from #541 Please feel free to mention me if there is any correction needed. |
AlexsJones
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @jatinmehrotra I have made a few suggestions on pinning to the issue
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
…section Signed-off-by: Jatin Mehrotra <jatin.mehrotra@classmethod.jp>
4ea2e4f
to
5bf7e92
Compare
docs: added "note" for events before further details section
…inmehrotra/k8sgpt into fix-readme-for-anonymization
AlexsJones
reviewed
Jul 19, 2023
AlexsJones
reviewed
Jul 19, 2023
AlexsJones
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
✅ Checks
ℹ Additional Information