Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use default values #568

Merged
merged 5 commits into from
Sep 19, 2023
Merged

fix: use default values #568

merged 5 commits into from
Sep 19, 2023

Conversation

jianzhangbjz
Copy link
Contributor

Closes # <!-- Issue #567 >

📑 Description

After this PR, it works as follows,

MacBook-Pro:k8sgpt jianzhang$ ./bin/k8sgpt auth add 
Warning: backend input is empty, will use the default value: openai
Warning: model input is empty, will use the default value: gpt-3.5-turbo
Enter openai Key: openai added to the AI backend provider list

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@jianzhangbjz jianzhangbjz requested review from a team as code owners July 20, 2023 08:08
@jianzhangbjz jianzhangbjz changed the title use default values fix: use default values Jul 20, 2023
@AlexsJones
Copy link
Member

Thanks for this contribution, I noticed a failing check we would be grateful if you could take a look! 🙏🏽

@jianzhangbjz
fix: use default values when adding auth
6391c7a 
The `auth add` cmd should use `backend` and `model` default values when user doesn't specify them

Closes: k8sgpt-ai#567

Signed-off-by: Jian Zhang <jiazha@redhat.com>
@jianzhangbjz
Copy link
Contributor Author

Hi @AlexsJones thanks for reviewing, I have updated it.

@jianzhangbjz
Copy link
Contributor Author

Hi @AlexsJones , seems like it needs the manual merge, could you help have a look? Thanks!

@jianzhangbjz
Copy link
Contributor Author

Hi @AlexsJones could you help merge it manually when you get a chance? Thanks!

@AlexsJones AlexsJones merged commit 7461a74 into k8sgpt-ai:main Sep 19, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
@jianzhangbjz jianzhangbjz deleted the default branch October 9, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexsJones AlexsJones AlexsJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jianzhangbjz @AlexsJones @thschue