-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use default values #568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this contribution, I noticed a failing check we would be grateful if you could take a look! 🙏🏽 |
The `auth add` cmd should use `backend` and `model` default values when user doesn't specify them Closes: k8sgpt-ai#567 Signed-off-by: Jian Zhang <jiazha@redhat.com>
Hi @AlexsJones thanks for reviewing, I have updated it. |
AlexsJones
reviewed
Jul 21, 2023
AlexsJones
approved these changes
Jul 25, 2023
Hi @AlexsJones , seems like it needs the manual merge, could you help have a look? Thanks! |
Hi @AlexsJones could you help merge it manually when you get a chance? Thanks! |
AlexsJones
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # <!-- Issue #567 >
📑 Description
After this PR, it works as follows,
✅ Checks
ℹ Additional Information