fix: --kubeconfig doesn't work

[jianzhangbjz]

Closes #604

📑 Description

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• All the tests have passed

ℹ Additional Information

[jianzhangbjz]

Hi @AlexsJones could you help review it when you get a chance? Thanks!

[arbreezy]

LGTM

[jianzhangbjz]

Hi @arbreezy , thanks for reviewing! But, could you help merge it manually? Or anything else I need to do? Thanks! Seems like it was blocked.

[arbreezy]

Hi @arbreezy , thanks for reviewing! But, could you help merge it manually? Or anything else I need to do? Thanks! Seems like it was blocked.

we need one more approval to merge it..
maybe @matthisholleville can merge this, I don't have access on this repo

[AlexsJones]

I had to back this out as I realised that if no kubeconfig is set as a parameter, then it will assume incluster - which is not correct. For example on my local machine:

    ~/Code/k8sgpt    main ?1  go run ./main.go analyze                               ✔ 
Error initialising kubernetes client: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined
Error: unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined

[jianzhangbjz]

Hi @AlexsJones , sorry, I'm a little bit confused. It works well in my local. As you know, if no kubeconfig is set, it will get KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT values from ENV variables, see https://github.com/kubernetes/client-go/blob/master/rest/config.go#L516 . So one question, did you export them on your local env? Thanks!

[jianzhangbjz]

Hi @AlexsJones , this #604 issue still exists, could you help revert #608? Or anything else I missed? Thanks! cc: @arbreezy

[arbreezy]

Hey @jianzhangbjz just a heads up, we merged a fix on this issue recently.

[jianzhangbjz]

Hi @arbreezy , got it, thanks!