-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: --kubeconfig doesn't work #605
Conversation
If user specify `--kubeconfig` when running k8sgpt, it should use the kubeconfig file to login the corresponding cluster instead of getting auth info via SA. Closes k8sgpt-ai#604 Signed-off-by: Jian Zhang <jiazha@redhat.com>
612cab9
to
5a5d61e
Compare
Hi @AlexsJones could you help review it when you get a chance? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @arbreezy , thanks for reviewing! But, could you help merge it manually? Or anything else I need to do? Thanks! Seems like it was blocked. |
we need one more approval to merge it.. |
This reverts commit e3b21ec.
I had to back this out as I realised that if no kubeconfig is set as a parameter, then it will assume incluster - which is not correct. For example on my local machine:
|
Hi @AlexsJones , sorry, I'm a little bit confused. It works well in my local. As you know, if no |
Hi @AlexsJones , this #604 issue still exists, could you help revert #608? Or anything else I missed? Thanks! cc: @arbreezy |
Hey @jianzhangbjz just a heads up, we merged a fix on this issue recently. |
Hi @arbreezy , got it, thanks! |
Closes #604
π Description
β Checks
βΉ Additional Information