Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Replace rest kubernetes client with controller-runtime clientset for Trivy integration analyzers #771

Closed
2 tasks done
arbreezy opened this issue Nov 24, 2023 · 2 comments · Fixed by #776
Closed
2 tasks done
Assignees
Labels
good first issue Good for newcomers

Comments

@arbreezy
Copy link
Member

arbreezy commented Nov 24, 2023

Checklist

  • I've searched for similar issues and couldn't find anything matching
  • I've discussed this feature request in the K8sGPT Slack and got positive feedback

Is this feature request related to a problem?

None

Problem Description

No response

Solution Description

We want to switch the k8s rest client to controller-runtime clientset which is already introduced. Effectively we are making requests to K8s api to fetch trivy CRs in a cluster and we just want to change the client interface

Benefits

Thew new client is a prominent k8s client wrapper used by popular controllers and scaffolding projects like kube builder with great support of interacting with Custom resources.

Testing CRs is also more readable and easier with controller-runtime clientset methods than using a dynamic k8s client

Potential Drawbacks

No response

Additional Information

No response

@arbreezy arbreezy added the good first issue Good for newcomers label Nov 24, 2023
@ptyin
Copy link
Contributor

ptyin commented Nov 24, 2023

Hi, I'd like to have a try. Could you assign me this issue? I would get you informed my progress by this weekend.

@arbreezy
Copy link
Member Author

Great assigning it to you @ptyin , you can check the gateway analysers to see an example, the goal is to deprecate the rest client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants