-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace rest client with controller-runtime clientset for Trivy analyzers #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, lgtm
your PR should comply with DCO though @ptyin , please have a look
β¦rivy analyzers Signed-off-by: ptyin <peteryin1604@gmail.com>
Done |
@ptyin I think we can also remove the rest client initialization aa well, |
Got it. |
We should modify the |
Yes exactly, unless there's anything still using the rest client which IIRC there isn't |
Signed-off-by: ptyin <peteryin1604@gmail.com>
Hi Aris, I have pushed another commit as required. Could you kindly re-review it? |
Closes #771
π Description
Replace the Trivy analyzer in the same manner as the one called by the Gateway analyzer.
β Checks
βΉ Additional Information