-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added tests for the PVC analyzer #1000
test: added tests for the PVC analyzer #1000
Conversation
6f0c993
to
74e07ae
Compare
This commit introduces comprehensive tests for the `PersistentVolumeClaim` analyzer defined in the `pkg/analyzer` package. Adding these tests increases the code coverage of the `pvc.go` file to >95%. I also made minor modifications to the ReplicaSet test to ensure all expectations were met. Partially addresses: k8sgpt-ai#889 Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
74e07ae
to
4be4738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @VaibhavMalik4187
}, | ||
}, | ||
{ | ||
name: "event other than privision failure", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks for reviewing and pointing this out. I'll take care of it in the upcoming PRs.
📑 Description
This commit introduces comprehensive tests for the
PersistentVolumeClaim
analyzer defined in thepkg/analyzer
package.Adding these tests increases the code coverage of the
pvc.go
file toI also made minor modifications to the ReplicaSet test to ensure all expectations were met.
Partially addresses: #889
✅ Checks