test: added tests for the PVC analyzer #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaibhavMalik4187
force-pushed
the
pvc-analyzer-tests
branch
from
6f0c993
to
74e07ae
Compare
This commit introduces comprehensive tests for the `PersistentVolumeClaim` analyzer defined in the `pkg/analyzer` package. Adding these tests increases the code coverage of the `pvc.go` file to >95%. I also made minor modifications to the ReplicaSet test to ensure all expectations were met. Partially addresses: k8sgpt-ai#889 Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
VaibhavMalik4187
force-pushed
the
pvc-analyzer-tests
branch
from
74e07ae
to
4be4738
Compare
arbreezy
approved these changes
Mar 8, 2024
arbreezy
reviewed
Mar 8, 2024
| }, | ||
| }, | ||
| { | ||
| name: "event other than privision failure", |
There was a problem hiding this comment.
Oops, thanks for reviewing and pointing this out. I'll take care of it in the upcoming PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This commit introduces comprehensive tests for the
PersistentVolumeClaimanalyzer defined in thepkg/analyzerpackage.Adding these tests increases the code coverage of the
pvc.gofile toI also made minor modifications to the ReplicaSet test to ensure all expectations were met.
Partially addresses: #889
✅ Checks