Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added tests for the PDB analyzer #1001

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

VaibhavMalik4187
Copy link
Contributor

📑 Description

This commit introduces comprehensive tests for the PodDisruptionBudget analyzer defined in the pkg/analyzer package.

Adding these tests increases the code coverage of the pdb.go file to >96%.

Additionally, a potential crash in case of empty or nil PDB status conditions has been addressed.

Partially addresses: #889

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@VaibhavMalik4187 VaibhavMalik4187 requested review from a team as code owners March 6, 2024 13:43
This commit introduces comprehensive tests for the `PodDisruptionBudget`
analyzer defined in the `pkg/analyzer` package.

Adding these tests increases the code coverage of the `pdb.go` file to
>96%.

Additionally, a potential crash in case of empty or nil PDB status
conditions has been addressed.

Partially addresses: k8sgpt-ai#889

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
@AlexsJones AlexsJones merged commit 1340ead into k8sgpt-ai:main Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants