-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalid ParentObj in output #1068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice catch @panpan0000 |
panpan0000
commented
Apr 17, 2024
arbreezy
requested changes
Apr 19, 2024
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
arbreezy
approved these changes
Apr 21, 2024
@panpan0000 we need to fix this test as well , https://github.com/k8sgpt-ai/k8sgpt/blob/main/pkg/util/util_test.go#L85 |
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
Thank you for reminder. @arbreezy , fixed as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GetParent()
always returnfalse
and the invoker never respect its return value.So add the boolean return value (I believe it means "found" )
Closes #1067
π Description
β Checks
βΉ Additional Information
Previous
![image](https://private-user-images.githubusercontent.com/14049268/323189077-236a969f-8128-4478-a42a-ddcd9c8fd9ff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NjA1NzYsIm5iZiI6MTcyNDQ2MDI3NiwicGF0aCI6Ii8xNDA0OTI2OC8zMjMxODkwNzctMjM2YTk2OWYtODEyOC00NDc4LWE0MmEtZGRjZDljOGZkOWZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAwNDQzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFkOTAwMWM3NDk2NzQ1ZDExOTM4ZjJkZjExZjBlZTgwMWI5MTk2ZTg1ODM1YTAwMjRmNjgyNzI5ZWI3NzMyNTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0RsypdSlgx80yUW6bfk9NmzR2sJ4ba6WnCdOv5tYRMM)
![image](https://private-user-images.githubusercontent.com/14049268/323189227-901d8dc4-df8e-47d4-aca1-330d34a0895a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0NjA1NzYsIm5iZiI6MTcyNDQ2MDI3NiwicGF0aCI6Ii8xNDA0OTI2OC8zMjMxODkyMjctOTAxZDhkYzQtZGY4ZS00N2Q0LWFjYTEtMzMwZDM0YTA4OTVhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI0VDAwNDQzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA1ZTI0ZjdhYWI1ODgwN2U3N2E2YzAyNmYyZDlhM2JhZjI2ODBhODgwYmI3NzgyOWQzN2I5MzIxZmQ3OWU1NGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ov-LH97wn5wchr9KbRRzL6asi26yBr5sRAKu_TF7hgc)
Now