-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ingress object meta value #144
fix: ingress object meta value #144
Conversation
Signed-off-by: Aris Boutselis <aris.boutselis@senseon.io>
Signed-off-by: Matthis Holleville <matthish29@gmail.com>
@matthisholleville looks good, no worries. |
Can you run : This is my output :
Do you have both errors? |
@arbreezy You are right that if you don't use the JSON output format, you only get the first error (regardless of the analyzer). I don't think it's related to ingress exclusively. We should open an issue? |
Yes with json output it looks good and code is fine, not sure why plain text isn't showing it. |
I already touched base on slack, going to have a proper look tomorrow as well, thanks for the prompt response @matthisholleville , most likely we need to open a new issue. |
@arbreezy Indeed, only the first error from the array is displayed : https://github.com/k8sgpt-ai/k8sgpt/blob/main/cmd/analyze/analyze.go#L144 |
Please check the bug fix I have proposed for the output and if it fixes your issue we can get this in also |
All errors are displaying correctly with your fix. Great job! |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #
π Description
A merge request that includes the modifications made in arbreezy merge request available #143 and adds Ingress to the switch case GetParents.
β Checks
βΉ Additional Information